square / maker

Maker Design System by Square
https://square.github.io/maker/styleguide/latest-stable/
Other
63 stars 14 forks source link

fix(text-button): add additional states and remove unused code #261

Closed landondurnan closed 2 years ago

landondurnan commented 2 years ago

Describe the problem this PR addresses

Recommended PR additions to: https://github.com/square/maker/pull/260 Missing some states output and we weren't using the same color as the button.

Describe the changes in this PR

CleanShot 2022-03-21 at 11 16 48 just outline-color change

CleanShot 2022-03-21 at 11 16 54 active / focus

Other information

github-actions[bot] commented 2 years ago

Styleguide deployed to https://square.github.io/maker/styleguide/text-button-change/#/

pretzelhammer commented 2 years ago

i don't see any changes to line height, maybe you forgot to push the commit? 🤔

landondurnan commented 2 years ago

@pretzelhammer It wasn't clear from the description this was against https://github.com/square/maker/pull/260, made some updates.