search

square / maker

Maker Design System by Square
https://square.github.io/maker/styleguide/latest-stable/
Other
63 stars 14 forks source link

chore: package audit fix #272

Closed landondurnan closed 2 years ago

landondurnan commented 2 years ago

Describe the problem this PR addresses

Getting warnings during npm install regarding some of the packages.

Describe the changes in this PR

Ran npm audit fix

Other information

There's still some reported vulnerabilities without an easy fix. I think it will require replacing some older unmaintained packages with newer equivalents. i.e. stylelint-config-rational-order with this: https://github.com/hudochenkov/stylelint-config-hudochenkov/blob/master/order.js

May also be worth looking at updating outdated packages:

Package                          Current   Wanted  Latest  Location
@commitlint/cli                   11.0.0   11.0.0  16.2.3  @square/maker
@commitlint/config-conventional   11.0.0   11.0.0  16.2.1  @square/maker
eslint                            7.32.0   7.32.0  8.12.0  @square/maker
eslint-config-airbnb-base         14.2.1   14.2.1  15.0.0  @square/maker
eslint-plugin-unicorn             22.0.0   22.0.0  41.0.1  @square/maker
eslint-plugin-vue                 7.20.0   7.20.0   8.5.0  @square/maker
fs-extra                           9.1.0    9.1.0  10.0.1  @square/maker
github-markdown-css                4.0.0    4.0.0   5.1.0  @square/maker
has-own-prop                       2.0.0    2.0.0   3.1.0  @square/maker
husky                              4.3.8    4.3.8   7.0.4  @square/maker
lint-staged                       10.5.4   10.5.4  12.3.7  @square/maker
markdown-table                     2.0.0    2.0.0   3.0.2  @square/maker
popmotion                          9.4.2    9.4.2  11.0.3  @square/maker
postcss-preset-env                 6.7.1    6.7.1   7.4.3  @square/maker
stylelint                        13.13.1  13.13.1  14.6.1  @square/maker
stylelint-config-css-modules       2.3.0    2.3.0   4.1.0  @square/maker
stylelint-config-standard         20.0.0   20.0.0  25.0.0  @square/maker
stylelint-order                    4.1.0    4.1.0   5.0.0  @square/maker
vue                               2.6.14   2.6.14  3.2.31  @square/maker
vue-loader                        15.9.8   15.9.8  17.0.0  @square/maker
vue-pseudo-window                  0.4.0    0.4.0   1.0.0  @square/maker
vue-router                         3.5.3    3.5.3  4.0.14  @square/maker
github-actions[bot] commented 2 years ago

Styleguide deployed to https://square.github.io/maker/styleguide/package-updates/#/

github-actions[bot] commented 2 years ago

📊 Package size report   3%↑

File Before After
components/ActionBar/script.js 14.5 kB 0.1%↑14.5 kB
components/Blade/script.js 6.2 kB -0.06%↓6.2 kB
components/Button/script.js 6.2 kB 0.1%↑6.3 kB
components/Calendar/script.js 7.7 kB 0.08%↑7.7 kB
components/Card/script.js 1.7 kB 0.5%↑1.7 kB
components/Checkbox/script.js 3.9 kB 0.05%↑3.9 kB
components/Container/script.js 4.5 kB 0.2%↑4.5 kB
components/Dialog/script.js 7.5 kB 0.8%↑7.6 kB
components/Divider/script.js 1.7 kB 0.5%↑1.7 kB
components/Heading/script.js 4.7 kB 0.2%↑4.7 kB
components/Image/script.js 3.3 kB 0.5%↑3.3 kB
components/ImageUploader/script.js 11.7 kB 0.7%↑11.8 kB
components/Loading/script.js 2.2 kB 0.4%↑2.2 kB
components/Modal/script.js 9.8 kB 0.7%↑9.9 kB
components/Notice/script.js 4.7 kB 0.09%↑4.7 kB
components/PinInput/script.js 4.5 kB 0.2%↑4.5 kB
components/Popover/script.js 9.9 kB 1%↑10.1 kB
components/ProgressBar/script.js 2.9 kB 0.3%↑2.9 kB
components/Radio/script.js 3.6 kB 0.06%↑3.6 kB
components/Skeleton/script.js 4.3 kB 24%↑5.3 kB
components/Stepper/script.js 4.2 kB 0.1%↑4.2 kB
components/Text/script.js 4.5 kB 0.2%↑4.5 kB
components/TextButton/script.js 3.7 kB 0.2%↑3.7 kB
components/Theme/script.js 5.5 kB 0.1%↑5.5 kB
components/Toggle/script.js 3.7 kB 0.05%↑3.7 kB
components/TouchCapture/script.js 3.5 kB 0.4%↑3.5 kB
components/TransitionFadeIn/script.js 2.3 kB 0.4%↑2.3 kB
components/TransitionResize/script.js 3.6 kB 0.4%↑3.6 kB
components/TransitionSpringLeft/script.js 2.3 kB 0.4%↑2.3 kB
components/TransitionSpringUp/script.js 2.3 kB 0.4%↑2.3 kB
components/TransitionStaggered/script.js 2.5 kB 0.3%↑2.5 kB
package.json 5.0 kB -0.62%↓5.0 kB
utils/BlockFormControlLayout/script.js 1.8 kB 0.4%↑1.8 kB
utils/InlineFormControlLayout/script.js 2.5 kB 0.3%↑2.6 kB
utils/Transition/script.js 2.4 kB 0.2%↑2.4 kB
utils/TransitionResponsive/script.js 2.2 kB 0.4%↑2.2 kB
utils/transitions.js 4.2 kB 2%↑4.3 kB
Total (Includes all files) 1.3 MB 3%↑1.3 MB
Tarball size 235.7 kB 6%↑248.8 kB
Unchanged files | File | Size | | ----------------------------------------------------------------------------- | -------: | | `components/ActionBar/index.js` | `46 B` | | `components/ActionBar/styles.css` | `5.5 kB` | | `components/Blade/index.js` | `46 B` | | `components/Blade/styles.css` | `742 B` | | `components/Button/index.js` | `46 B` | | `components/Button/styles.css` | `3.6 kB` | | `components/Calendar/index.js` | `46 B` | | `components/Calendar/styles.css` | `2.0 kB` | | `components/Card/index.js` | `46 B` | | `components/Card/styles.css` | `196 B` | | `components/Checkbox/index.js` | `46 B` | | `components/Checkbox/styles.css` | `1.3 kB` | | `components/Choice/index.js` | `46 B` | | `components/Choice/script.js` | `4.5 kB` | | `components/Choice/styles.css` | `1.2 kB` | | `components/Container/index.js` | `46 B` | | `components/Container/styles.css` | `1.0 kB` | | `components/Dialog/index.js` | `46 B` | | `components/Dialog/styles.css` | `1.3 kB` | | `components/Divider/index.js` | `46 B` | | `components/Divider/styles.css` | `160 B` | | `components/Heading/index.js` | `46 B` | | `components/Heading/styles.css` | `5.1 kB` | | `components/Image/index.js` | `46 B` | | `components/Image/styles.css` | `208 B` | | `components/ImageUploader/index.js` | `46 B` | | `components/ImageUploader/styles.css` | `2.3 kB` | | `components/Input/index.js` | `46 B` | | `components/Input/script.js` | `4.2 kB` | | `components/Input/styles.css` | `2.1 kB` | | `components/Loading/index.js` | `46 B` | | `components/Loading/styles.css` | `1.2 kB` | | `components/Modal/index.js` | `46 B` | | `components/Modal/styles.css` | `1.1 kB` | | `components/Notice/index.js` | `46 B` | | `components/Notice/styles.css` | `983 B` | | `components/PinInput/index.js` | `46 B` | | `components/PinInput/styles.css` | `1.2 kB` | | `components/Popover/index.js` | `46 B` | | `components/Popover/styles.css` | `446 B` | | `components/ProgressBar/index.js` | `46 B` | | `components/ProgressBar/styles.css` | `1.1 kB` | | `components/Radio/index.js` | `46 B` | | `components/Radio/styles.css` | `1.4 kB` | | `components/SegmentedControl/index.js` | `46 B` | | `components/SegmentedControl/script.js` | `3.1 kB` | | `components/SegmentedControl/styles.css` | `870 B` | | `components/Select/index.js` | `46 B` | | `components/Select/script.js` | `5.0 kB` | | `components/Select/styles.css` | `1.9 kB` | | `components/Skeleton/index.js` | `46 B` | | `components/Skeleton/styles.css` | `889 B` | | `components/StarRating/index.js` | `46 B` | | `components/StarRating/script.js` | `5.9 kB` | | `components/StarRating/styles.css` | `322 B` | | `components/Stepper/index.js` | `46 B` | | `components/Stepper/styles.css` | `402 B` | | `components/Text/index.js` | `46 B` | | `components/Text/styles.css` | `5.1 kB` | | `components/Textarea/index.js` | `46 B` | | `components/Textarea/script.js` | `3.6 kB` | | `components/Textarea/styles.css` | `1.4 kB` | | `components/TextButton/index.js` | `46 B` | | `components/TextButton/styles.css` | `1.4 kB` | | `components/Theme/index.js` | `46 B` | | `components/Theme/styles.css` | `136 B` | | `components/Toggle/index.js` | `46 B` | | `components/Toggle/styles.css` | `3.5 kB` | | `components/TouchCapture/index.js` | `25 B` | | `components/TransitionFadeIn/index.js` | `25 B` | | `components/TransitionResize/index.js` | `25 B` | | `components/TransitionSpringLeft/index.js` | `25 B` | | `components/TransitionSpringUp/index.js` | `25 B` | | `components/TransitionStaggered/index.js` | `25 B` | | [`LICENSE`](https://github.com/square/maker/blob/package-updates/LICENSE) | `552 B` | | [`README.md`](https://github.com/square/maker/blob/package-updates/README.md) | `327 B` | | `utils/assert.js` | `1.1 kB` | | `utils/BlockFormControlLayout/index.js` | `46 B` | | `utils/BlockFormControlLayout/styles.css` | `234 B` | | `utils/debug.js` | `1.0 kB` | | `utils/get-contrast.js` | `1.1 kB` | | `utils/InlineFormControlLayout/index.js` | `46 B` | | `utils/InlineFormControlLayout/styles.css` | `380 B` | | `utils/Transition/index.js` | `25 B` | | `utils/TransitionResponsive/index.js` | `25 B` |
Hidden files | File | Before | After | | ----------------------------------------------- | --------: | -----------------------: | | `components/ActionBar/script.js.map` | `55.4 kB` | 5%↑`58.2 kB` | | `components/ActionBar/styles.css.map` | `18.3 kB` | `18.3 kB` | | `components/Blade/script.js.map` | `23.3 kB` | 4%↑`24.3 kB` | | `components/Blade/styles.css.map` | `3.9 kB` | `3.9 kB` | | `components/Button/script.js.map` | `24.7 kB` | 3%↑`25.6 kB` | | `components/Button/styles.css.map` | `10.6 kB` | `10.6 kB` | | `components/Calendar/script.js.map` | `29.5 kB` | 4%↑`30.6 kB` | | `components/Calendar/styles.css.map` | `10.3 kB` | `10.3 kB` | | `components/Card/script.js.map` | `8.8 kB` | 0.6%↑`8.9 kB` | | `components/Card/styles.css.map` | `711 B` | `711 B` | | `components/Checkbox/script.js.map` | `18.6 kB` | 2%↑`19.0 kB` | | `components/Checkbox/styles.css.map` | `3.6 kB` | `3.6 kB` | | `components/Choice/script.js.map` | `19.7 kB` | 4%↑`20.4 kB` | | `components/Choice/styles.css.map` | `5.9 kB` | `5.9 kB` | | `components/Container/script.js.map` | `18.1 kB` | 4%↑`18.7 kB` | | `components/Container/styles.css.map` | `4.9 kB` | `4.9 kB` | | `components/Dialog/script.js.map` | `28.9 kB` | 5%↑`30.2 kB` | | `components/Dialog/styles.css.map` | `7.0 kB` | `7.0 kB` | | `components/Divider/script.js.map` | `8.8 kB` | 0.6%↑`8.9 kB` | | `components/Divider/styles.css.map` | `723 B` | `723 B` | | `components/Heading/script.js.map` | `22.4 kB` | 4%↑`23.4 kB` | | `components/Heading/styles.css.map` | `11.6 kB` | `11.6 kB` | | `components/Image/script.js.map` | `14.1 kB` | 5%↑`14.8 kB` | | `components/Image/styles.css.map` | `2.9 kB` | `2.9 kB` | | `components/ImageUploader/script.js.map` | `45.9 kB` | 4%↑`47.9 kB` | | `components/ImageUploader/styles.css.map` | `20.2 kB` | `20.2 kB` | | `components/Input/script.js.map` | `20.1 kB` | 2%↑`20.5 kB` | | `components/Input/styles.css.map` | `4.9 kB` | `4.9 kB` | | `components/Loading/script.js.map` | `11.0 kB` | 1%↑`11.2 kB` | | `components/Loading/styles.css.map` | `2.3 kB` | `2.3 kB` | | `components/Modal/script.js.map` | `34.9 kB` | 6%↑`37.0 kB` | | `components/Modal/styles.css.map` | `10.7 kB` | `10.7 kB` | | `components/Notice/script.js.map` | `18.6 kB` | 3%↑`19.2 kB` | | `components/Notice/styles.css.map` | `4.2 kB` | `4.2 kB` | | `components/PinInput/script.js.map` | `18.4 kB` | 4%↑`19.1 kB` | | `components/PinInput/styles.css.map` | `7.0 kB` | `7.0 kB` | | `components/Popover/script.js.map` | `35.1 kB` | 8%↑`37.8 kB` | | `components/Popover/styles.css.map` | `5.7 kB` | `5.7 kB` | | `components/ProgressBar/script.js.map` | `13.3 kB` | 3%↑`13.6 kB` | | `components/ProgressBar/styles.css.map` | `2.6 kB` | `2.6 kB` | | `components/Radio/script.js.map` | `17.5 kB` | 3%↑`17.9 kB` | | `components/Radio/styles.css.map` | `3.5 kB` | `3.5 kB` | | `components/SegmentedControl/script.js.map` | `14.1 kB` | 3%↑`14.6 kB` | | `components/SegmentedControl/styles.css.map` | `3.3 kB` | `3.3 kB` | | `components/Select/script.js.map` | `23.0 kB` | 2%↑`23.5 kB` | | `components/Select/styles.css.map` | `5.7 kB` | `5.7 kB` | | `components/Skeleton/script.js.map` | `17.7 kB` | 51%↑`26.8 kB` | | `components/Skeleton/styles.css.map` | `3.0 kB` | `3.0 kB` | | `components/StarRating/script.js.map` | `22.3 kB` | 3%↑`22.9 kB` | | `components/StarRating/styles.css.map` | `6.3 kB` | `6.3 kB` | | `components/Stepper/script.js.map` | `17.3 kB` | 3%↑`17.9 kB` | | `components/Stepper/styles.css.map` | `3.8 kB` | `3.8 kB` | | `components/Text/script.js.map` | `21.5 kB` | 4%↑`22.5 kB` | | `components/Text/styles.css.map` | `10.9 kB` | `10.9 kB` | | `components/Textarea/script.js.map` | `17.6 kB` | 3%↑`18.0 kB` | | `components/Textarea/styles.css.map` | `3.8 kB` | `3.8 kB` | | `components/TextButton/script.js.map` | `16.8 kB` | 3%↑`17.3 kB` | | `components/TextButton/styles.css.map` | `4.2 kB` | `4.2 kB` | | `components/Theme/script.js.map` | `21.4 kB` | 3%↑`22.0 kB` | | `components/Theme/styles.css.map` | `2.2 kB` | `2.2 kB` | | `components/Toggle/script.js.map` | `19.6 kB` | 2%↑`20.0 kB` | | `components/Toggle/styles.css.map` | `5.4 kB` | `5.4 kB` | | `components/TouchCapture/script.js.map` | `12.0 kB` | 6%↑`12.8 kB` | | `components/TransitionFadeIn/script.js.map` | `10.5 kB` | 1%↑`10.6 kB` | | `components/TransitionResize/script.js.map` | `14.4 kB` | 6%↑`15.2 kB` | | `components/TransitionSpringLeft/script.js.map` | `10.5 kB` | 1%↑`10.7 kB` | | `components/TransitionSpringUp/script.js.map` | `10.5 kB` | 1%↑`10.6 kB` | | `components/TransitionStaggered/script.js.map` | `11.1 kB` | 5%↑`11.6 kB` | | `utils/assert.js.map` | `4.2 kB` | 0.7%↑`4.2 kB` | | `utils/BlockFormControlLayout/script.js.map` | `8.4 kB` | 0.4%↑`8.5 kB` | | `utils/BlockFormControlLayout/styles.css.map` | `762 B` | `762 B` | | `utils/debug.js.map` | `3.6 kB` | 1%↑`3.6 kB` | | `utils/get-contrast.js.map` | `4.9 kB` | 0.5%↑`5.0 kB` | | `utils/InlineFormControlLayout/script.js.map` | `12.8 kB` | 1%↑`13.0 kB` | | `utils/InlineFormControlLayout/styles.css.map` | `1.5 kB` | `1.5 kB` | | `utils/Transition/script.js.map` | `10.7 kB` | 2%↑`11.0 kB` | | `utils/TransitionResponsive/script.js.map` | `10.3 kB` | 3%↑`10.6 kB` | | `utils/transitions.js.map` | `16.8 kB` | 5%↑`17.7 kB` |

🤖 This report was automatically generated by pkg-size-action

landondurnan commented 2 years ago

Very curious about the 24% increase on components/Skeleton/script.js edit: looks to be a package size increase on https://github.com/privatenumber/vue-frag

github-actions[bot] commented 2 years ago

Styleguide deployed to https://square.github.io/maker/styleguide/package-updates/#/

landondurnan commented 2 years ago

Closing this one in favor of smaller set of updates: https://github.com/square/maker/pull/276 this one was revealing some issues with running the lab script with some packages.