square / maker

Maker Design System by Square
https://square.github.io/maker/styleguide/latest-stable/
Other
63 stars 14 forks source link

Maker Inputs Autofill handling #332

Closed sonatata closed 2 years ago

sonatata commented 2 years ago

Feature request

When users have saved information on their browser, autofill will render input fields as such on Chrome:

image

Why?

Would be nice to have the Maker Input and Select components handle this rather than the consumer

Alternatives

adding this fixes the issue for chrome on the consumer side for inputs

  input:-webkit-autofill,
  input:-webkit-autofill:hover, 
  input:-webkit-autofill:focus, 
  input:-webkit-autofill:active{
      -webkit-box-shadow: 0 0 0 30px var(--neutral-0) inset !important;
      -webkit-text-fill-color: var(--neutral-100) !important;
  }

Additional context

No response

pretzelhammer commented 2 years ago

closing as i believe this was fixed in this merged pr: https://github.com/square/maker/pull/382