Closed laurenhu closed 2 years ago
Deployed Styleguide and Lab.Notes
the Button Customization lab is great! thanks for making it. i played around with it and was impressed how by both the fill variant and the outline variant maintained their character and their accessibility despite my most devious efforts to destroy both. I'm guessing you didn't include the ghost variant because most of the customizations would not apply to it, but it'd still be interesting to see it in context if you don't mind adding it.
this pr was a little difficult to review because it has a lot of extraneous diffs but i did my best :) i look forward to giving it a follow-up review once my initial comments have been resolved and once master
has been merged in & merge conflicts are resolved.
Deployed Styleguide and Lab.Notes
File | Before | After |
---|---|---|
components/Button/script.js |
5.5 kB |
54%↑8.5 kB |
components/Button/styles.css |
5.2 kB |
15%↑6.0 kB |
Total (Includes all files) | 1.7 MB |
1%↑1.7 MB |
Tarball size | 325.3 kB |
2%↑331.3 kB |
🤖 This report was automatically generated by pkg-size-action
I looked through the most recent commit and to be honest I don't think Shimaa would have been a fan of expandable
or textPattern
props on buttons. Buttons having consistent sizes is important for site layout and site visual cohesiveness/consistency. By adding expandable
and textPattern
buttons can be made all kinds of weird and odd heights now. Furthermore, I think it was intended for Buttons to always have the label
style with the label font family and label font weight... being able to change it to the paragraph
style or even the title
or headline
styles is pretty weird, especially since the button's padding is not responsive to the text changes so any buttons using the title
or headline
styles look bad/cramped/claustrophobic.
At the end of the day if Website needs it then we'll ship it, but I'd just like to make sure that everyone involved is aware of the negative design implications of these changes.
Describe the problem this PR addresses
Buttons currently do not support custom border, box-shadow, shape and hover styles
Describe the changes in this PR
Adds support to buttons for custom border, box-shadow, shape and hover styles
Other information