Closed pretzelhammer closed 1 year ago
Deployed Styleguide and Lab.Notes
File | Before | After |
---|---|---|
components/ImageUploader/script.js |
11.7 kB |
-7.95%↓10.8 kB |
components/ImageUploader/styles.css |
2.4 kB |
-10.3%↓2.2 kB |
components/Theme/script.js |
16.1 kB |
3%↑16.5 kB |
Total (Includes all files) | 1.8 MB |
-0.18%↓1.8 MB |
Tarball size | 336.6 kB |
-0.19%↓336.0 kB |
🤖 This report was automatically generated by pkg-size-action
:tada: This PR is included in version 15.4.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Describe the problem this PR addresses
before, the icons used within MImageUploader were not themeable, and now they are
also, there was a bug where if an image with transparency was uploaded the image preview would show the placeholder icon behind the image itself, which looked bad, my fix for now is just to remove the placeholder icon, as this bug was overlooked for so long because it has no impact on our users and the placeholder icon rarely shows up in the first place. in the future we might add a more generic placeholder icon if users ever start using ImageUploader as a generic file uploader (which it technically supports today but nobody uses it like that)
Describe the changes in this PR
replaces inline maker icons with micons and adds
plus
andarrowUp
icons to the default icons in the default themeOther information
styleguide docs: https://square.github.io/maker/styleguide/themeable-image-upload/#/ImageUploader