Closed pretzelhammer closed 1 year ago
File | Before | After |
---|---|---|
components/Theme/script.js |
16.7 kB |
0.5%↑16.8 kB |
Total (Includes all files) | 1.8 MB |
0.02%↑1.8 MB |
Tarball size | 336.1 kB |
0.05%↑336.3 kB |
🤖 This report was automatically generated by pkg-size-action
This PR has been automatically closed because it hasn't received any activity in over 3 months.
Describe the problem this PR addresses
not meant for merging, just for documentation, for addressing bugs raised in this issue https://github.com/square/maker/issues/479
Describe the changes in this PR
adds reactive patterns lab
Other information
notes to self:
undefined
andnull
illegal values for any propundefinded
ornull
value it should throw an error... it would be slightly better DX if it silently resolved to the default theme value HOWEVER i think this will likely cause subtle bugs to pop up in the future so i think it's better to fail loudly & obviously rather than silently & subtly even if the latter will produce behavior that will work for most (but not all) scenarios for most (but not all) of the timeundefined
s andnull
s should be ignored for the purposes of merging/overriding