Closed pretzelhammer closed 1 year ago
Deployed Styleguide and Lab.Notes
File | Before | After |
---|---|---|
components/ProgressCircle/script.js |
3.9 kB |
1%↑4.0 kB |
components/Theme/script.js |
16.8 kB |
0.07%↑16.9 kB |
Total (Includes all files) | 1.8 MB |
0.02%↑1.8 MB |
Tarball size | 342.5 kB |
0.02%↑342.5 kB |
🤖 This report was automatically generated by pkg-size-action
Describe the problem this PR addresses
ProgressCircle props, specifically the icon ones, are not pattern-friendly, and not consistent with Toast's icon props
Describe the changes in this PR
makes ProgressCircle and Toast APIs consistent in how icons are configured via props. this was originally discussed in the mvp Toast PR. it looks a little clunky at the moment but it will make way more sense once we add info, warning, success, and error patterns to ProgressCircle, which i will do in a follow-up PR.
Other information
https://square.github.io/maker/styleguide/progress-circle-show-icon/#/ProgressCircle