search

square / maker

Maker Design System by Square
https://square.github.io/maker/styleguide/latest-stable/
Other
63 stars 14 forks source link

fix(touchcapture): stop generating noisy console error #530

Closed athammer closed 1 year ago

athammer commented 1 year ago

Describe the problem this PR addresses

Some events are not cancelable such as scrolling. We try to cancel theses events even though browser's wont' let us leading to an error in the console which is picked up by error monitoring.

To replicate go to: https://www.justonemoreplantco.com/events-and-workshops Click "Philadelphia Flower Show Bus Trip" to bring up the modal scroll down a bit then try to drag all the way down

https://user-images.githubusercontent.com/16027039/223269826-6500fc2b-e74f-4dd8-a660-e7a5c59e1b56.mov

Describe the changes in this PR

No UI changes only we should check if an event is cancelable before we actually try to cancel it.

Other information

athammer commented 1 year ago

seems like the GAs failed but isn't related to the code? - doesn't seem like i can rerun them. i'll push an empty commit

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 17.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: