search

square / maker

Maker Design System by Square
https://square.github.io/maker/styleguide/latest-stable/
Other
63 stars 14 forks source link

fix(icon): fail gracefully if icon not defined in theme #537

Closed pretzelhammer closed 1 year ago

pretzelhammer commented 1 year ago

Describe the problem this PR addresses

an error being thrown in this edge case is a bit harsh as it can break/crash an app when it's not that big of a deal

Describe the changes in this PR

emit a warning instead, and fallback to rendering info icon instead

Other information

nope

github-actions[bot] commented 1 year ago

Deployed Styleguide and Lab.

Notes
  1. Links may take a few minutes to update after PR is opened or commit is pushed.
  2. Links may become invalidated after PR is merged or closed.
  3. Links for all releases and open PRs can be found on the Maker Deploys page.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 17.2.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: