search

square / maker

Maker Design System by Square
https://square.github.io/maker/styleguide/latest-stable/
Other
63 stars 14 forks source link

refactor!: standardize sizes between MIcon & MLoading #538

Closed pretzelhammer closed 1 year ago

pretzelhammer commented 1 year ago

Describe the problem this PR addresses

to quote the updated migration docs in this pr:

The size prop values for MLoading did not match those of MIcon, which is a problem because MLoading was recently refactored to use MIcon internally. They now match. Also the size prop for either MLoading or MIcon can now also take any arbitrary valid CSS value for width or height. The default sizes for both components remains unchanged.

Describe the changes in this PR

to quote the updated migration docs in this pr:

The size prop values for MLoading did not match those of MIcon, which is a problem because MLoading was recently refactored to use MIcon internally. They now match. Also the size prop for either MLoading or MIcon can now also take any arbitrary valid CSS value for width or height. The default sizes for both components remains unchanged.

Other information

github-actions[bot] commented 1 year ago

Deployed Styleguide and Lab.

Notes
  1. Links may take a few minutes to update after PR is opened or commit is pushed.
  2. Links may become invalidated after PR is merged or closed.
  3. Links for all releases and open PRs can be found on the Maker Deploys page.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 18.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: