search

square / maker

Maker Design System by Square
https://square.github.io/maker/styleguide/latest-stable/
Other
63 stars 14 forks source link

fix(icon): fix default icon color inheritence #556

Closed laurenhu closed 1 year ago

laurenhu commented 1 year ago

Describe the problem this PR addresses

This fixes an icon color bug. Icons with no color prop declared are not inheriting the parent color as desired, but inheriting the nearest parent definition of --color, which typically happens on the nearest MTheme. This causes a bug on button loaders where instead of applying the button color, it applies the MTheme color instead.

Describe the changes in this PR

This PR replaces --color: inherit with --color: currentColor, which fixes the color inheritance bug.

Screenshot 2023-06-23 at 4 12 34 PM Screenshot 2023-06-23 at 4 12 14 PM Screenshot 2023-06-23 at 4 27 16 PM

Other information

github-actions[bot] commented 1 year ago

Deployed Styleguide and Lab.

Notes
  1. Links may take a few minutes to update after PR is opened or commit is pushed.
  2. Links may become invalidated after PR is merged or closed.
  3. Links for all releases and open PRs can be found on the Maker Deploys page.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 18.0.10 :tada:

The release is available on:

Your semantic-release bot :package::rocket: