search

square / maker

Maker Design System by Square
https://square.github.io/maker/styleguide/latest-stable/
Other
63 stars 14 forks source link

feat(text): balance letter-spacing when centered #561

Closed privatenumber closed 1 year ago

privatenumber commented 1 year ago

Describe the problem this PR addresses

When the text is centered with letter spacing, it isn't center aligned:

Screenshot 2023-08-18 at 12 34 13 AM

This is being addressed in Maker because it's a CSS-level issue (not a project specific one): https://adamschwartz.co/magic-of-css/potions/letter-spacing

Describe the changes in this PR

Add padding left to balance it out:

Screenshot 2023-08-18 at 12 34 02 AM

Other information

github-actions[bot] commented 1 year ago

Deployed Styleguide and Lab.

Notes
  1. Links may take a few minutes to update after PR is opened or commit is pushed.
  2. Links may become invalidated after PR is merged or closed.
  3. Links for all releases and open PRs can be found on the Maker Deploys page.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 19.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: