search

square / maker

Maker Design System by Square
https://square.github.io/maker/styleguide/latest-stable/
Other
63 stars 14 forks source link

perf(image): use static size styles for safari #576

Closed kevinlee11 closed 10 months ago

kevinlee11 commented 10 months ago

Describe the problem this PR addresses

Still trying to narrow down a fix for the Safari scroll issues.

Describe the changes in this PR

Using overrides in Safari, setting a static height/width style on the images after they render seems to solve the perf issue. Tested on a photo layout site to ensure the images resize properly switching between desktop/mobile. Will only enable this prop for Safari.

github-actions[bot] commented 10 months ago

Deployed Styleguide and Lab.

Notes
  1. Links may take a few minutes to update after PR is opened or commit is pushed.
  2. Links may become invalidated after PR is merged or closed.
  3. Links for all releases and open PRs can be found on the Maker Deploys page.

github-actions[bot] commented 10 months ago

:tada: This PR is included in version 19.6.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket: