search

square / maker

Maker Design System by Square
https://square.github.io/maker/styleguide/latest-stable/
Other
63 stars 14 forks source link

fix(text): prevent always running detect text alignment #578

Closed wkashdan closed 6 months ago

wkashdan commented 6 months ago

Describe the problem this PR addresses

This pull request is meant to improve browser performance of the Text component. The current implementation causes the browser to recompute actual styles each time a text component is mounted and/or updated. This occurs only to fix an issue with letter spacing.

Describe the changes in this PR

This PR ensure the logic to detect center styling only runs if custom letter spacing is passed in to the component, otherwise there is no need to run this.

Other information

This issue frequently causes Safari to do a force layout calculation which is inefficient.

pretzelhammer commented 6 months ago

the CI checks failed because they ran against your repo (wkashdan/maker) instead of the main repo (square/maker). I added you to the Maker Contributors team so you should now have permissions to make the PR directly on square/maker where the CI checks can run properly.

wkashdan commented 6 months ago

Closing this in favor of https://github.com/square/maker/pull/579