search

square / maker

Maker Design System by Square
https://square.github.io/maker/styleguide/latest-stable/
Other
63 stars 14 forks source link

fix(text): prevent always running detect text alignment #579

Closed wkashdan closed 6 months ago

wkashdan commented 6 months ago

Describe the problem this PR addresses

This pull request is meant to improve browser performance of the Text component. The current implementation causes the browser to recompute actual styles each time a text component is mounted and/or updated. This occurs only to fix an issue with letter spacing.

Describe the changes in this PR

This PR ensure the logic to detect center styling only runs if custom letter spacing is passed in to the component, otherwise there is no need to run this.

Other information

This issue frequently causes Safari to do a force layout calculation which is inefficient.

github-actions[bot] commented 6 months ago

Deployed Styleguide and Lab.

Notes
  1. Links may take a few minutes to update after PR is opened or commit is pushed.
  2. Links may become invalidated after PR is merged or closed.
  3. Links for all releases and open PRs can be found on the Maker Deploys page.

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 19.6.9 :tada:

The release is available on:

Your semantic-release bot :package::rocket: