square / metrics

Metrics Query Engine
Apache License 2.0
170 stars 21 forks source link

Remove unnecesarry escaping for names with dots #246

Closed Nathan-Fenner closed 8 years ago

Nathan-Fenner commented 8 years ago

A recent change which allowed the query labels to correctly escape their contents was overzealous. In particulae, foo.bar would always be escaped because of the ., even though this is a legal identifier.

This PR updates the identifier regex used in escaping to reflect this, and updates the tests to correct this oversight.

@drcapulet

drcapulet commented 8 years ago

:+1: