Move out `AddMetric(s)` methods from `MetricAPI`

square / metrics

Metrics Query Engine

Apache License 2.0

170 stars 21 forks source link

Move out `AddMetric(s)` methods from `MetricAPI` #278

Closed Nathan-Fenner closed 8 years ago

Nathan-Fenner commented 8 years ago

The majority of the code doesn't need to be able to AddMetric(s) to the metric API, since normal queries aren't allowed to modify the index (they can only read it).

"UI" has been renamed to "web" for clarity.

"Query" has been replaced with "console" for clarity, and no longer uses liner. This removes this dependency from MQE.

drcapulet commented 8 years ago

LGTM

Nathan-Fenner commented 8 years ago

Just made some changes to the Cached API that are worth looking at before final merge.

drcapulet commented 8 years ago

Few comments, otherwise LGTM