search

square / mortar

A simple library that makes it easy to pair thin views with dedicated controllers, isolated from most of the vagaries of the Activity life cycle.
Apache License 2.0
2.16k stars 156 forks source link

Fix Dagger2 shifting sands #122

Closed rjrjr closed 9 years ago

rjrjr commented 9 years ago 
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Mortar (Parent) .................................... SUCCESS [  0.455 s]
[INFO] Mortar ............................................. SUCCESS [  6.010 s]
[INFO] Dagger1 Support .................................... SUCCESS [  4.463 s]
[INFO] Dagger2 Support .................................... SUCCESS [  2.115 s]
[INFO] Hello Mortar ....................................... SUCCESS [  9.320 s]
[INFO] Mortar Sample ...................................... SUCCESS [ 10.812 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34.181 s
[INFO] Finished at: 2015-01-22T18:20:29-08:00
[INFO] Final Memory: 58M/422M
[INFO] ------------------------------------------------------------------------
pyricau commented 9 years ago

LGTM :+1:

chrisjenx commented 9 years ago

@pyricau @rjrjr can you release another snapshot? The latest one seems to have not picked up this merge. (The source shows the code of the previous snapshot, and the bug with name mismatch still exists).

rjrjr commented 9 years ago

Fixed.

On Fri Jan 23 2015 at 6:52:59 AM Christopher Jenkins < notifications@github.com> wrote:

@pyricau https://github.com/pyricau @rjrjr https://github.com/rjrjr can you release another snapshot? The latest one seems to have not picked up this merge. (The source shows the code of the previous snapshot, and the bug with name mismatch still exists).

— Reply to this email directly or view it on GitHub https://github.com/square/mortar/pull/122#issuecomment-71203914.

chrisjenx commented 9 years ago

Thanks.

rjrjr commented 9 years ago

Thanks for using it!

On Fri Jan 23 2015 at 8:11:39 AM Christopher Jenkins < notifications@github.com> wrote:

Thanks.

— Reply to this email directly or view it on GitHub https://github.com/square/mortar/pull/122#issuecomment-71216863.

chrisjenx commented 9 years ago

Dagger2 + Mortar + Flow. Pretty much 100%, just testing is a bit tricky.

On Fri Jan 23 2015 at 4:27:51 PM rjrjr notifications@github.com wrote:

Thanks for using it!

On Fri Jan 23 2015 at 8:11:39 AM Christopher Jenkins < notifications@github.com> wrote:

Thanks.

— Reply to this email directly or view it on GitHub https://github.com/square/mortar/pull/122#issuecomment-71216863.

— Reply to this email directly or view it on GitHub https://github.com/square/mortar/pull/122#issuecomment-71219672.