fix(BundleServiceComparator): use ternary operator instead of Integer#compare() that requires API level 19

square / mortar

A simple library that makes it easy to pair thin views with dedicated controllers, isolated from most of the vagaries of the Activity life cycle.

Apache License 2.0

2.16k stars 156 forks source link

Closed DmitriyZaitsev closed 9 years ago

DmitriyZaitsev commented 9 years ago

Hi! I suggest to replace Integer.compare with ternary operator:

That method added in API level 19 but Mortar supports much lower API versions;
Since in this block array lengths are different, so result can be only 1 or -1 and now it's more obvious for reading.

rjrjr commented 9 years ago

Wow, that's nuts. Thanks for the fix, but please sign our CLA so that I can merge it. https://github.com/square/mortar/blob/master/CONTRIBUTING.md

DmitriyZaitsev commented 9 years ago

I've signed it. Thanks.