search

square / mortar

A simple library that makes it easy to pair thin views with dedicated controllers, isolated from most of the vagaries of the Activity life cycle.
Apache License 2.0
2.16k stars 156 forks source link

Mortar sample with Flow 1.0.0-alpha #185

Open alexrwegener opened 8 years ago

alexrwegener commented 8 years ago

Any plans to provide a sample with the latest version of flow?

loganj commented 8 years ago

More likely is a Flow integration module, but not until after Flow 1.0 beta.

leonardo2204 commented 8 years ago

@alexrwegener I'm implementing a sample project using both If you may, check it out ! Contributions and feedback are pretty welcome !

ScottPierce commented 7 years ago

It'd be great if there was some movement on this. Flow has changed a lot and it's not obvious how to integrate Mortar with it based on the samples. The samples seem all over the place, and are somewhat confusing. It'd be great if there was some movement on this to add clarity, and show that this project was still active.

Zhuinden commented 7 years ago

Considering there is a service locator embedded inside Flow 1.0-alpha that is kept alive by Flow's KeyManager, it doesn't really make sense to use another service locator on top of it (Mortar).

rjrjr commented 7 years ago

I'm on vacation at the moment. When I get back to work I'll be focusing in flow 1.0, and in particular moving our most complex mortar app to use it.

I agree that their turfs have started to overlap, but I don't think they're redundant yet.

On Thu, Mar 30, 2017, 5:38 PM Gabor Varadi notifications@github.com wrote:

Considering there is a service locator embedded inside Flow 1.0-alpha that is kept alive by Flow's KeyManager, it doesn't really make sense to use another service locator on top of it (Mortar).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/square/mortar/issues/185#issuecomment-290575269, or mute the thread https://github.com/notifications/unsubscribe-auth/ABzBHcJEYbuX44a0ccwZMXPxG00HpSHiks5rrD0MgaJpZM4Hewox .

rjrjr commented 7 years ago

Getting into the thick of this now, migrating a large app that leans very heavily on Mortar. Rather than migrate all of our Mortar provided services to Flow, I'm making MortarScopes the only service that Flow provides. Maybe eventually we'll bother to turn everything into a Flow service, maybe that won't be worth the effort.

Not thinking too hard yet about how I'd start from scratch. mortar.Scoped is pretty handy, and there is a useful kernel to mortar.Bundled. Perhaps the thing is to create new versions of them in Flow? Perhaps a new Mortar Lite library that builds on top of Flow?