search

square / mortar

A simple library that makes it easy to pair thin views with dedicated controllers, isolated from most of the vagaries of the Activity life cycle.
Apache License 2.0
2.16k stars 155 forks source link

Remove ViewPresenter's hard dependency on android.view.View #191

Closed majormajors closed 8 years ago

majormajors commented 8 years ago

This decouples ViewPresenter from Android's View class

rjrjr commented 8 years ago

Thanks for the PR, but I'm not even thrilled that ViewPresenter is in Mortar. And I really don't want to deal with a breaking change for all current uses of it.

It's so easy to write your own convenience class of this type, they seem more appropriate as gists than as library code.

majormajors commented 8 years ago

That makes sense. Thanks for the review.