search

square / okhttp

Square’s meticulous HTTP client for the JVM, Android, and GraalVM.
https://square.github.io/okhttp/
Apache License 2.0
45.69k stars 9.14k forks source link

Ensure builds run with a specific JVM version #8192

Open yschimke opened 7 months ago

yschimke commented 7 months ago 
          > ```

e: file:///home/runner/work/okhttp/okhttp/okhttp/src/main/kotlin/okhttp3/OkHttpClient.kt:257:33 Type mismatch: inferred type is Long but Int was expected e: file:///home/runner/work/okhttp/okhttp/okhttp/src/main/kotlin/okhttp3/OkHttpClient.kt:615:27 Type mismatch: inferred type is Int but Long was expected e: file:///home/runner/work/okhttp/okhttp/okhttp/src/main/kotlin/okhttp3/OkHttpClient.kt:1298:22 Type mismatch: inferred type is Int but Long was expected e: file:///home/runner/work/okhttp/okhttp/okhttp/src/main/kotlin/okhttp3/OkHttpClient.kt:1326:24 Type mismatch: inferred type is Int but Long was expected

Thanks. I figured out the issue with gradle. I had my JVM set to Java 8. It works with Java 21.

Now these should be gone.

Originally posted by @ArloL in https://github.com/square/okhttp/issues/8189#issuecomment-1890454018

We should fail earlier with a clear message in these cases. Or maybe gradle has a way to cause that?

swankjesse commented 5 months ago

Or even better, let’s configure Gradle to build on a consistent JVM, regardless of what your environment provides.

yschimke commented 5 months ago

https://jakewharton.com/gradle-toolchains-are-rarely-a-good-idea/

I guess if we bump this up high, like the latest LTS, it's not terrible?

JakeWharton commented 5 months ago

LTS releases are for JVM deployments where you are unable to upgrade for (mostly illogical) reasons. Aside from compatibility with build tooling, there's no reason not to use the latest JDK. The best LTS version is the latest version, as it's where security fixes and performance improvements land first.