square / okio

A modern I/O library for Android, Java, and Kotlin Multiplatform.
https://square.github.io/okio/
Apache License 2.0
8.72k stars 1.17k forks source link

ZipFileSystem doesn’t honor local time zone on Kotlin/Native #1440

Open swankjesse opened 4 months ago

swankjesse commented 4 months ago

The DOS date format assumes file times use the local machine’s zone offsets, but we’re using UTC only.

Could fix by taking a dependency on kotlinx-datetime once that library reaches 1.0.

Could fix on Windows and Apple platforms by finding native APIs for time zone mapping. I’m unsure about whether such APIs are available without dependencies on Linux.

The impact of this is low because ZIP files may also include a date stamp in the extended format which doesn’t have this limitation. I haven’t yet done the research to learn how common that extension is among the .zip files that users are likely to encounter.