search

square / okio

A modern I/O library for Android, Java, and Kotlin Multiplatform.
https://square.github.io/okio/
Apache License 2.0
8.72k stars 1.17k forks source link

Usage of `kotlin-node` declarations from kotlin-wrappers #1443

Closed sgrishchenko closed 4 months ago

sgrishchenko commented 4 months ago

As far as I can see, you use your own Kotlin declarations for Node fs module (FsJs.kt). Do you consider usage of kotlin-node declarations from kotlin-wrappers repository? I am an author of these declarations, so if it is interesting for you, I can help with integration.

swankjesse commented 4 months ago

As a general rule, Okio doesn’t take on any dependencies. We absolutely don’t take dependencies on software that hasn’t reached 1.0.

I don’t think this specific dependency is necessary ‘cause we’ve already solved this problem.

I also don’t like the possible complexity of what happens when we want to use a Node API that isn’t yet in a released version of these wrappers.

All that said, the wrappers project looks awesome and I look forward to using it in my other non-library projects!