search

square / okio

A modern I/O library for Android, Java, and Kotlin Multiplatform.
https://square.github.io/okio/
Apache License 2.0
8.72k stars 1.17k forks source link

Release compatible with Kotlin 2.0 #1489

Open nreid260 opened 3 weeks ago

nreid260 commented 3 weeks ago

Is there an ETA for a Kotlin 2.0 compatible release?

I totally understand that kotlinc v2.0.0 only became available very recently!

JakeWharton commented 3 weeks ago

The existing release is compatible. Are you having problems?

nreid260 commented 2 weeks ago

Nope, seems to work! Very speedy.

We did have a bit of trouble with Timeout.cancel shadowing cancel from an outer class, but that's an us problem.

nreid260 commented 2 weeks ago

I spoke to soon https://github.com/square/okio/pull/1490 seems to be needed

JakeWharton commented 2 weeks ago

That's only needed for when we upgrade to build with Kotlin 2.0, right? The existing release remains compatible.

nreid260 commented 2 weeks ago

okio 3.9.0 is compatible with -language-mode=1.9, but we want to build with -language-mode=2.0

JakeWharton commented 2 weeks ago

Is there a reason you're building, as opposed to using our deployed artifacts?

nreid260 commented 2 weeks ago

We build from source as much as possible for security reasons. Also for Kotlin-native, we might be compiling for different architectures.

JakeWharton commented 2 weeks ago

Ah, I clicked your profile and I see now who "we" are and things are making sense. I, too, once suffered in the great monorepo.