search

square / papa

PAPA: Performance of Android Production Applications
Apache License 2.0
351 stars 15 forks source link

CurrentFrameMetricsListener is counting UNKNOWN_DELAY_DURATION duration twice? #21

Closed snijsure closed 2 years ago

snijsure commented 2 years ago

While browsing some code noticed that

In class CurrentFrameMetricsListener -- line 47, 48 is double counting UNKNOWN_DELAY_DURATION twice?

  val drawEndNanos =
      frameMetrics.getMetric(INTENDED_VSYNC_TIMESTAMP) +
        frameMetrics.getMetric(FrameMetrics.UNKNOWN_DELAY_DURATION) +
        frameMetrics.getMetric(FrameMetrics.UNKNOWN_DELAY_DURATION) +
pyricau commented 2 years ago

Thanks for finding this!