search

square / pysurvival

Open source package for Survival Analysis modeling
https://www.pysurvival.io/
Apache License 2.0
350 stars 106 forks source link

Warning Thrown when using `save_model` #10

Open peterskipper opened 5 years ago

peterskipper commented 5 years ago

I'm using the save_model function to save a ConditionalRandomSurvivalForest model for churn. When I do, I repeatedly see a warning:

python3.5/site-packages/pyarrow/pandas_compat.py:113: FutureWarning: A future version of pandas will default to `skipna=True`. To silence this warning, pass `skipna=True|False` explicitly

I would like to remove this warning, but unfortunately neither the save_model func nor the random forest object's save method allow me to pass in kwargs like skipna.

Package Versions:

My best guess is that the issue is on this line: https://github.com/square/pysurvival/blob/dd4c5bfd39c92cacc7f8e3c7061cde5f61890c38/pysurvival/models/__init__.py#L83

Can we update save_model to accept kwargs?