It includes a couple commits that are unlikely to affect correctness:
quiet signedness comparison build warnings - adjust some int / size_t
typing to avoid comparisons of different signedness
remove some unused variables
It also includes a couple changes that will likely improve correctness (it
would be good to get additional review of these):
fix some logical vs bitwise operator cases - fix tests in some if and
while statements that were using bitwise operators (&, |) where
probably the logical operators (&&, ||) were intended
avoid undefined behavior in SurvivalForest Data get() and getIndex() - these
could reach end of function without an explicit return, resulting in
undefined behavior. Appropriate return value not clear in those cases, so
raise an exception.
A couple remaining build warnings are not addressed by this PR:
a few more int vs size_t signedness comparison complaints from
cython-generated code. These would require only minor changes to
_coxpy.pyx and _svm.pyx, and regeneration of the cpp files with
cython. Regenerating with current cython generates very large diffs
so those changes are not included here.
complaints about use of deprecated numpy APIs when building the
cython-generated sources. Didn't investigate whether this would require
any pyx code changes or just regeneration with current cython.
This PR quiets some build warnings from g++.
It includes a couple commits that are unlikely to affect correctness:
quiet signedness comparison build warnings - adjust some
int/size_ttyping to avoid comparisons of different signednessremove some unused variables
It also includes a couple changes that will likely improve correctness (it would be good to get additional review of these):
fix some logical vs bitwise operator cases - fix tests in some
ifandwhilestatements that were using bitwise operators (&,|) where probably the logical operators (&&,||) were intendedavoid undefined behavior in SurvivalForest Data get() and getIndex() - these could reach end of function without an explicit return, resulting in undefined behavior. Appropriate return value not clear in those cases, so raise an exception.
A couple remaining build warnings are not addressed by this PR:
a few more
intvssize_tsignedness comparison complaints from cython-generated code. These would require only minor changes to_coxpy.pyxand_svm.pyx, and regeneration of thecppfiles with cython. Regenerating with current cython generates very large diffs so those changes are not included here.complaints about use of deprecated numpy APIs when building the cython-generated sources. Didn't investigate whether this would require any
pyxcode changes or just regeneration with current cython.