square / pysurvival

Open source package for Survival Analysis modeling
https://www.pysurvival.io/
Apache License 2.0
347 stars 107 forks source link

Typos in utils.metrics.compare_to_actual function #29

Open gedeon1310 opened 3 years ago

gedeon1310 commented 3 years ago

There might be typos in utils.metrics at lines 340 and 348 (_compare_toactual function)

I assume this shoulde be:

(340) _results['median_absolute_error'] = medae instead of _results['median_absoluteerror'] = rmse (348) _results['mean_absoluteerror'] = mae instead of _results['mean_absoluteerror'] = rmse

Thanks for the great repo !