square / pysurvival

Open source package for Survival Analysis modeling
https://www.pysurvival.io/
Apache License 2.0
347 stars 107 forks source link

Tutorials use time-varying covariates as if they are fixed #35

Open ebsnap opened 3 years ago

ebsnap commented 3 years ago

I could be wrong about this, as I am new to the survival analysis literature, but my understanding is that time-varying covariates must be given special treatment in any survival analysis:

https://www.jstor.org/stable/pdf/27643698.pdf?ab_segments=0%252Fbasic_SYC-5187_SYC-5188%252F5187&refreqid=excelsior%3A0aaa616b818456a7135b22942f8307e0 https://lifelines.readthedocs.io/en/latest/Time%20varying%20survival%20regression.html https://cran.r-project.org/web/packages/survival/vignettes/timedep.pdf https://www.annualreviews.org/doi/pdf/10.1146/annurev.publhealth.20.1.145

However, the tutorials for this project use time-varying covariates as if they are fixed over time:

https://square.github.io/pysurvival/tutorials/employee_retention.html

Is this problematic ?