search

square / radiography

Text-ray goggles for your Android UI.
Apache License 2.0
851 stars 35 forks source link

Support Compose 1.6 and 1.7 #169

Closed elihart closed 2 months ago

elihart commented 2 months ago

This PR makes a few updates to get all tests passing on the latest compose 1.7 beta version, addressing some changes for 1.6 and 1.7.

First, it addresses an issue due to 1.6 (https://github.com/square/radiography/issues/159) by adding calls to currentComposer.collectParameterInformation() within test functions. This fixes tests within Radiography to make the project compatible, but does not address the potential of providing some functionality to end users to apply this easily. It is a fairly easy function to add, so perhaps the documentation should just be updated to included a note about this (I didn't attempt to do that in this PR though)

The other main fix is to the findTestTags function and compose renderer - these broke because they were trying to read semantic information from the compose modifiers; in newer versions of compose the semantics information is only present in semantic nodes. I had previously updated Radiography to expose that data for Compose 1.5 (https://github.com/square/radiography/pull/157) but these usage sites hadn't been updated and had broken.

rjrjr commented 2 months ago

Thanks Eli! @pyricau @zach-klippenstein, do you have bandwidth to review?