search

square / rails-auth

Modular resource-based authentication and authorization for Rails/Rack
Apache License 2.0
291 stars 23 forks source link

Update config_builder.rb #47

Closed marivaldo closed 6 years ago

marivaldo commented 6 years ago

change var load acl. Evaluate the code for merge possibility

tarcieri commented 6 years ago

This looks good to me but I no longer work at Square and don't have permission to merge this.

marivaldo commented 6 years ago

ok @tarcieri, do you dont't have a contact on square, to verify this update? :smiley:

somethingnew2-0 commented 6 years ago

Looks good to me

mdayaram commented 6 years ago

Hmmmm, is there any way we can add a test to make sure this is configured correctly? Maybe check the middleware after loading it and introspect the ACL?

tarcieri commented 6 years ago

Yeah, it'd be good to add a config_builder_spec.rb that calls the application method and exercises at least the development and test environment methods, perhaps using mock objects. Obviously testing production would be ideal as well, although a bit more tricky.

mdayaram commented 6 years ago

I'll add a TODO to add a test, but for now, this is great. Thanks for your contribution!