Fix typescript type for manual card entry payment type

square / react-native-square-reader-sdk

React Native Plugin for Square Reader SDK

Apache License 2.0

117 stars 36 forks source link

Fix typescript type for manual card entry payment type #214

Closed fobos531 closed 6 months ago

fobos531 commented 1 year ago

Summary

The current type definitions mention that card is a valid AdditionalPaymentType - however, when checking out the native code of the Reader SDK, the native SDKs expect manual_card_entry to be used. This PR fixes the type definition so the correct string is used.

Related issues

Fix #

Changelog

adjust the type of the card AdditionalPaymentType to be manual_card_entry in accordance to the usage in the native SDKs

Test Plan

N/A

CLAassistant commented 1 year ago

All committers have signed the CLA.

fobos531 commented 1 year ago

@CharmisG Any chance to getting this merged?

fobos531 commented 11 months ago

Hey @tamerbader , would it be possible to get this merged?