square / retrofit

A type-safe HTTP client for Android and the JVM
https://square.github.io/retrofit/
Apache License 2.0
43.16k stars 7.31k forks source link

Latest available version of converter-gson artifact contains security vulnerability transitively. #3928

Closed TWiStErRob closed 1 year ago

TWiStErRob commented 1 year ago

What kind of issue is this?

image

https://devhub.checkmarx.com/cve-details/CVE-2022-25647/

Since Retrofit's last release 2.9.0 (2020) there have been some dependency updates:

among a ton of other maintenance and fixes, but there was no release of Retrofit.

Are there plans to release a new version?

JakeWharton commented 1 year ago

We will release when we release. This library has not been a priority recently, but is otherwise stable and working.

In general, both in the past over the history of the project and in the future, we will never do a release to solely address an issue bump for a transitive dependency. Those come along for the ride with new features and bug fixes within this library.

If you want a version newer than we can provide them then I would recommend a sibling dependency declaration with the newer version. This relies on normal Gradle dependency resolution semantics to resolve to the newer version and allows tools like Renovate to update your version when newer ones are available. If the library provides binary compatibility guarantees, as almost all should within a major version, Retrofit's converters and adapters will continue to work just fine.

TWiStErRob commented 1 year ago

to solely address an issue bump for a transitive dependency

Of course, this is issue is just one tiny reason in addition to the 3 years of maintenance updates and enhancements.

JakeWharton commented 1 year ago

Yes this is not the only vulnerability in a transitive dependency. Unfortunately the project isn't quite in a state that I'm comfortable releasing so it requires some time to get back to a releasable state.