search

square / spacecommander

Commit fully-formatted Objective-C as a team without even trying.
Other
1.13k stars 177 forks source link

Add compile time check script. #26

Closed alanf closed 8 years ago

alanf commented 9 years ago

Fixes #25

@JALsnipe

justinseanmartin commented 8 years ago

Rather than running against all sources in the branch, wouldn't it be much faster for large projects to just run against git rev-parse HEAD^? Also, it allows for incremental fixing of style, rather than complaining about the entire repo all at once.

JALsnipe commented 8 years ago

Thanks @alanf! Will check this out!

alanf commented 8 years ago

Since this is a compile-time check, the entire repo should be checked, just like the entire repo has to compile....Mainly, I'm considering the case where someone makes a "work in progress" commit and then tries compiling and bypasses the checks.

alanf commented 8 years ago

Closing since I'm not sure that there is any demand for this feature. If anyone would like compile time checks please create a new issue!