square / spoon

Distributing instrumentation tests to all your Androids.
https://square.github.io/spoon/
Apache License 2.0
2.7k stars 476 forks source link

Skip quering active tests if singleInstrumentationCall=true #504

Closed lsuski closed 6 years ago

lsuski commented 6 years ago

According to source code of SpoonDeviceRunner quering active tests (running adb shell am instrument log) is only useful if singleInstrumentationCall=false. Depending on number of tests and framework used it can take some time which is unnecessary

JakeWharton commented 6 years ago

Want to send a PR?

On Mon, Dec 4, 2017 at 10:15 AM Łukasz Suski notifications@github.com wrote:

According to source code of SpoonDeviceRunner quering active tests (running adb shell am instrument log) is only useful if singleInstrumentationCall=false. Depending on number of tests and framework used it can take some time which is unnecessary

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/square/spoon/issues/504, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEXy6Mlk0-KXCdWiJVKlUJGirjNlqks5s9AyPgaJpZM4Q0zus .

lsuski commented 6 years ago

No problem

lsuski commented 6 years ago

Actually, there is a problem :), because Spoon still needs runName and testCount. I'll try to figure out how to obtain these values without running through all tests

lsuski commented 6 years ago

I don't think it is possible to obtain number of tests and run name in different way so this can be closed.