search

square / spoon

Distributing instrumentation tests to all your Androids.
https://square.github.io/spoon/
Apache License 2.0
2.7k stars 477 forks source link

Switch to kotlin-stdlib-jdk8, update gradle, AGP, kotlin, fix warnings #548

Closed edenman closed 6 years ago

edenman commented 6 years ago

Addresses #547 (thanks, @jaredsburrows!)

jaredsburrows commented 6 years ago

@edenman Thank you. The sad part is in projects that use AGP 3.2.0/3.3.0+, people will have this problem again:

$ gradlew dependencies | grep -is jre
<-------------> 0% EXECUTING [2s]
> :dependencies > Resolve dependencies of :compileClasspath
     |    |         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0
     |    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-jre7:1.2.0
     |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
     |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
     |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
     |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
     +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
     |    |         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0
     |    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-jre7:1.2.0
     |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
     |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
     |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
     |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
<-------------> 0% EXECUTING [2s]in:kotlin-stdlib-jre8:1.2.0 (*)
> :dependencies > Resolve dependencies of :default
|    |    |         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0
|    |    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-jre7:1.2.0
|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
|    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
|    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
|    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
|    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
|    |    |         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0
|    |    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-jre7:1.2.0
|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
|    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)
|    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jre8:1.2.0 (*)

Filed bug here: https://issuetracker.google.com/issues/117136845.