Question marks in a query don't match number of arguments lint check

square / sqlbrite

A lightweight wrapper around SQLiteOpenHelper which introduces reactive stream semantics to SQL operations.

https://square.github.io/sqlbrite/3.x/sqlbrite/

Apache License 2.0

4.57k stars 416 forks source link

Question marks in a query don't match number of arguments lint check #220

Closed geralt-encore closed 6 years ago

geralt-encore commented 6 years ago

https://github.com/square/sqlbrite/issues/58

This is my first lint check so I am not sure if I've covered all the cases. I was using Timber lint checks as a reference. I'll appreciate any feedback!

JakeWharton commented 6 years ago

Thanks! I'll take a look soon here. If you're feeling generous you can rebase on the latest master for build fixes and version updates.

geralt-encore commented 6 years ago

Rebased generously :)

JakeWharton commented 6 years ago

@jrodbx when you get back from vacation can you take a quick look at this?

geralt-encore commented 6 years ago

Cool! Thanks for the review.

geralt-encore commented 6 years ago

Thanks for the review @jrodbx !

JakeWharton commented 6 years ago

Thanks!