square / sqlbrite

A lightweight wrapper around SQLiteOpenHelper which introduces reactive stream semantics to SQL operations.
https://square.github.io/sqlbrite/3.x/sqlbrite/
Apache License 2.0
4.57k stars 416 forks source link

Many "Action1" should replaced by "Consumer" in readme.md file #248

Closed artshell closed 6 years ago

artshell commented 6 years ago

eg:

Observable<Query> users = db.createQuery("users", "SELECT * FROM users");
users.subscribe(new Action1<Query>() {
  @Override public void call(Query query) {
    Cursor cursor = query.run();
    // TODO parse data...
  }
});

after:

Observable<Query> users = db.createQuery("users", "SELECT * FROM users");
users.subscribe(new Consumer<Query>() {
  @Override public void accept(Query query) {
    Cursor cursor = query.run();
    // TODO parse data...
  }
});

@JakeWharton

qyxxjd commented 6 years ago

Action1 from RxJava 1.x and SQL Brite 1.x Consumer from RxJava 2.x and SQL Brite 2.x/3.x

JakeWharton commented 6 years ago

PR welcome

On Sun, Jul 8, 2018 at 9:56 PM 续写经典 notifications@github.com wrote:

Action1 from RxJava 1.x and SQL Brite 1.x Consumer from RxJava 2.x and SQL Brite 2.x/3.x

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/square/sqlbrite/issues/248#issuecomment-403338065, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEcLp_ktghUEaCekVY6V7lhROoyz4ks5uErgxgaJpZM4VGqxA .