search

square / square-ruby-sdk

Ruby client library for the Square API
https://developer.squareup.com/docs
Other
70 stars 42 forks source link

remove deprecated faraday-middleware #96

Closed v-kumar closed 2 years ago

v-kumar commented 2 years ago

Faraday::Middleware has been deprecated since 2020. Using this also prevents migrating to Faraday 2.0 for all the users of this gem. This gem is the only gem that's preventing us from moving to Faraday 2.0 and migrating to Rails 7.0+.

This gem relies on two features of Faraday::Middleware. following redirects and gzip.

Using two separate gems (per Faraday and Faraday::Middleware) to achieve the same functionality.

More information at: https://github.com/lostisland/awesome-faraday/#middleware

v-kumar commented 2 years ago

Any update on this @wolfadex, @hukid ?

It's concerning the lack of any response to this PR or issue https://github.com/square/square-ruby-sdk/issues/74.

wolfadex commented 2 years ago

@v-kumar thank you for the PR. As with all of our SDK PRs we appreciate you taking the time to find a fix and will take it into consideration and apply it, if possible, internally.

Our SDKs are generated, and as such PRs have to be applied to the generator and not the SDK directly. We do have a scheduled release coming up on April 20th of the SDKs that should include a fix for this.