search

square / svelte-store

529 stars 35 forks source link

1.0.0.beta #33

Closed Akolyte01 closed 2 years ago

benjamin-t-frost commented 2 years ago

I think it would be best if this PR were pulled apart; with a diff so large that's not derived from a single change the quality of feedback is likely to suffer.

Akolyte01 commented 2 years ago

I think it would be best if this PR were pulled apart; with a diff so large that's not derived from a single change the quality of feedback is likely to suffer.

This is a staging ground so that all of the features can get be beta tested together. Individual changes can be examined by looking at specific commits, if needed, but this PR is not intended for direct review.

Akolyte01 commented 2 years ago

Amazing work @Akolyte01 :) Really, great job!

I have just one thought... persisted stores give us an easy way of adding and updating storage (local, session, cookie). Did you consider how to remove them easily too? I read new documentation but there is nothing about that.

I feel like if your module provides a way for creating storages, then should provide a way for removing them too.

Alternative: Manual storage removing - In this scenario you can just mention if someone wants remove storage must do this manually :)

Storages are really snippy if you forget to remove data. Especially localStorage because refreshing and closing the browser didn't change anything.

Yeah that seems reasonable.

smblee commented 2 years ago

How is 1.0 looking? do you need any help reviewing/testing anything?

Akolyte01 commented 2 years ago

How is 1.0 looking? do you need any help reviewing/testing anything?

@smblee it is going well, I'd say.

The plan is before considering this to be out of beta and merging to main, to convert over square's current codebase that uses SSS completely to the new features. This is taking longer mainly because I was out for a week and are currently in a hack week.

There are a couple bug fixes in the works and one big new feature -- rebounce.

Eyes on this PR would be great! https://github.com/square/svelte-store/pull/35

smblee commented 2 years ago

Could you explain the rationale behind rebounce/reload being opt-in rather than enabled by default?