Split transfer data because of the size limit of FileChannelImpl

square / tape

A lightning fast, transactional, file-based FIFO for Android and Java.

https://square.github.io/tape/

Apache License 2.0

2.47k stars 287 forks source link

Open wecharyu opened 2 years ago

wecharyu commented 2 years ago

Split the data that need to transfer into pieces with a maximum size Integer.MAX_VALUE
Add a unit test to cover the case of transferring large data (more than 2GB)

In the underlying FileChannelImpl, it can transfer at most 2 GB data at a time, which will cause an error if we transfer more than 2 GB data directly: https://github.com/square/tape/blob/445cd3fd0a7b3ec48c9ea3e0e86663fe6d3735d8/tape/src/main/java/com/squareup/tape2/QueueFile.java#L462-L464

JakeWharton commented 2 years ago

Change looks good. I need to update our CI which I can't do until next week. After that I'll rebase your changes to ensure they pass and merge.

wecharyu commented 2 years ago

Gentle Ping @JakeWharton, btw do we need to release a new version for this fix?

JakeWharton commented 2 years ago

Forgot about it. I'll try again next week.

wecharyu commented 2 years ago

Hi @JakeWharton please try this PR this week. Thanks a lot :)

JakeWharton commented 2 years ago

I have some other work and then I'm going on vacation. Earliest I'll get to this library is in September.

wecharyu commented 2 years ago

OHOK thank you, have a good vacation~

elevenfive commented 1 year ago

Hey @JakeWharton just a re-ping, maybe this got lost in the shuffle...

wecharyu commented 1 year ago

Hi @JakeWharton, please help check this PR at your convenience.

elevenfive commented 9 months ago

Yearly re-ping? Or close the issue?