Consider swapping the generic parameters on ContainerViewController

square / workflow-swift

A Swift and Kotlin library for making composable state machines, and UIs driven by those state machines.

https://square.github.io/workflow

Apache License 2.0

321 stars 44 forks source link

Consider swapping the generic parameters on ContainerViewController #6

Closed bencochran closed 4 years ago

bencochran commented 4 years ago

ContainerViewController is currently ContainerViewController<Output, Rendering> whereas AnyWorkflow is AnyWorkflow<Rendering, Output>. This inconsistency has tripped me up a few times, and I don’t personally see a concrete reason for this ordering over the other. If we want to make these match, pre-1.0’s the time.

AquaGeek commented 4 years ago

I'd be fine changing this to make them consistent. Any thoughts, @dhavalshreyas?

FYI, we have 55 usages of this internally, so not terrible to migrate.