search

squarefeet / ShaderParticleEngine

A GLSL-heavy particle engine for THREE.js. Originally based on Stemkoski's great particle engine (see README)
http://squarefeet.github.io/ShaderParticleEngine/
MIT License
850 stars 115 forks source link

Examples don't work properly on Three.js r84 #119

Closed allanbueno closed 7 years ago

allanbueno commented 7 years ago

This Particle Engine is awesome, but it is not working properly on Three.js r84.

When I tried to use the MultipleEmitters example with this version of Three.js, only one emitter is showed in the screen. There are other examples that don't work too, but I believe the problem is the same.

Thanks.

squarefeet commented 7 years ago

I noticed this a few days ago when I started doing some other bugfixes. I know the problem and have a fix in place already, but won't get released for a week or so until the rest of it is ready.

Would it help you if I issued a hotfix to master so you get working with this lib sooner?

allanbueno commented 7 years ago

Thank you very much for replying so quickly.

Yes, a hotfix will be great to get it working sooner.

squarefeet commented 7 years ago

Sure, I'll get one out as soon as I can :)

allanbueno commented 7 years ago

OK, I will wait! Thanks again :)

squarefeet commented 7 years ago

I figured since I have a few spare moments I'd be best getting it done, so v1.0.6 is ready for you on master. I've not published to NPM yet, so if you're needing it as an NPM module, I should have that ready soon.

Let me know if this fixes your issue!

UPDATE: NPM module has been updated.

allanbueno commented 7 years ago

It is working perfectly now :)

Thank you again for replying and also for making this useful lib.

squarefeet commented 7 years ago

Awesome, thanks!