squat / generic-device-plugin

A Kubernetes device plugin to schedule generic Linux devices
Apache License 2.0
208 stars 23 forks source link

USB: Fix parsing of device files #4

Closed duckfullstop closed 1 year ago

duckfullstop commented 1 year ago

Turns out I wrote this completely wrong 🙃

This also adds a little extra logging for when things go wrong, as well as tweaking some of the codepaths to hopefully make testing a little easier (something I'd like to add when I get some spare time).

duckfullstop commented 1 year ago

Oh geez Git threw an absolute wobbler with the merge commit here - not sure if you want to merge this or whether I should attempt to unmangle it with some force pushing?

squat commented 1 year ago

We can squash and merge and it's like nothing happened, it seems like only the very last commit is significant here, so luckily reviewing isn't difficult