squeak-smalltalk / squeak-app

Squeak/Smalltalk release bundles
https://files.squeak.org
43 stars 8 forks source link

Adds support for GitHub Actions #22

Closed marceltaeumel closed 3 years ago

marceltaeumel commented 3 years ago

Here is an example on what it will look like: https://github.com/marceltaeumel/squeak-app/actions/runs/1262385209

Details:

Next steps:

I will take a look at sign/notarize soon. Maybe one of you is more experienced in this field already and can thus help out. :-)

marceltaeumel commented 3 years ago

Can we also address this issue (duplicate squeak.sh file) or should this go into a separate PR?

Since this is not directly related to supporting GHA, this would be a separate PR.

As part of this change, could we also consider replacing the recurring "Hi all!" commit by a GitHub action that sends the failure mail to the list (something like this)? I think this would make the commit history look cleaner and it's also more transparent. :-)

Well, GitHub Actions has no support for e-mail notification yet. Using one of the existing mail-send actions, we would need a custom e-mail account for such things. We don't have one at the moment. I would rather not use a personal one for such things.

The recurring "Hi all!" commit is not needed anymore because only Travis had those e-mail notifications, which we used for scheduled runs.

LinqLover commented 3 years ago

With a bit of delay, thanks for the explanations! :-)

As part of this change, could we also consider replacing the recurring "Hi all!" commit by a GitHub action that sends the failure mail to the list (something like this)? I think this would make the commit history look cleaner and it's also more transparent. :-)

Well, GitHub Actions has no support for e-mail notification yet. Using one of the existing mail-send actions, we would need a custom e-mail account for such things. We don't have one at the moment. I would rather not use a personal one for such things.

I already have a working dummy account for exactly this purpose (already using this for some other repos). If you are interested, I can DM you the credentials. :-)

Can we also address this issue (duplicate squeak.sh file) or should this go into a separate PR?

Since this is not directly related to supporting GHA, this would be a separate PR.

Just created https://github.com/squeak-smalltalk/squeak-app/issues/23, will do at any time later if no one else anticipates me. :-)