search

squeak-smalltalk / squeak-filesystem

FileSystem is a Smalltalk API for accessing files and directories. This is an implementation for Squeak/Smalltalk.
Other
5 stars 3 forks source link

Add `FSFileDirectoryAdapter >> #deleteDirectory:` #6

Closed LinqLover closed 2 years ago

LinqLover commented 2 years ago

Complements ToolBuilder-Morphic-ct.280 for the Squeak Trunk, which adds a remove button to the directory chooser (which is specialized by Squot to use FileSystem-Git).

j4yk commented 2 years ago

Please remind me of this when the method is integrated in Squeak trunk.

LinqLover commented 2 years ago

Please remind me of this when the method is integrated in Squeak trunk.

Ah, this was a misconception. :-) This PR does not depend on any inbox versions, it just improves the compatibility of FileSystems with FileDirectory. This compatibility will be required in Squit's directory chooser (when adding/removing packages) once ToolBuilder-Morphic-ct.280 is merged into the Trunk, which adds a delete entry to the directory chooser.

This PR can be merged at any time. :-)

j4yk commented 2 years ago

Alright then.

LinqLover commented 2 years ago

Thank you for the review! :-)