squeak-smalltalk / squeak-object-memory

Issues and assets related to the Squeak object memory.
https://bugs.squeak.org
MIT License
12 stars 1 forks source link

MVCUIManager>>#confirm: does not automatically wrap long text -- but Morphic does #13

Closed tcj closed 2 years ago

tcj commented 2 years ago

As usual, a #confirm: with embedded newlines:

self confirm: 'We respect your privacy. To minimize your receipt 
of duplicate information and for internal recordkeeping purposes, 
Squeak may track responses, if any, to this offer. Read more about 
Squeak''s privacy policy.'

in MVC, becomes:

Screen Shot 2022-04-30 at 8 39 38 AM

while without the embedded newlines:

self confirm: 'We respect your privacy. To minimize your receipt of duplicate information and for internal recordkeeping purposes, Squeak may track responses, if any, to this offer. Read more about Squeak''s privacy policy.'

becomes in MVC:

Screen Shot 2022-04-30 at 8 38 26 AM

This is probably very standard behavior... but note that it becomes a problem w/r/t the (very cool btw :) ) welcome text in Utilities class>>#setAuthorInitials — which in MVC looks like this:

Screen Shot 2022-04-30 at 8 42 09 AM

Compare this to Morphic's implementation: Somewhere in DialogWindow / UserDialogBoxMorph, the text gets wrapped:

Screen Shot 2022-04-30 at 8 49 54 AM

(Note that the example text I used here was just lazily stolen from a bulk email, and is not something that would actually appear in Squeak.)

LinqLover commented 2 years ago

I'm pretty sure that I have fixed this a few weeks ago, are you using the latest Trunk?

tcj commented 2 years ago

@LinqLover indeed, this is in 21674, which I just downloaded today. 21674 seems to be from 2022-04-28

LinqLover commented 2 years ago

Sorry for the confusion! There is an unmerged patch for this at the moment, I hope I will be able to improve and merge it soon: https://lists.squeakfoundation.org/pipermail/squeak-dev/2022-April/219789.html mvcLineLengthDialogs

marceltaeumel commented 2 years ago

Merged: