search

squeak-smalltalk / squeak-object-memory

Issues and assets related to the Squeak object memory.
https://bugs.squeak.org
MIT License
11 stars 1 forks source link

'preserver trash' prefference ceased to work #80

Closed vaidasd closed 11 months ago

vaidasd commented 1 year ago

It works for Squeak6.0 at update: #22104, but does not work update: #22122

codeZeilen commented 11 months ago

Some initial insight on this issue: The feature still works, but the deleted morphs are put on weird locations within the pages of the trash book.

codeZeilen commented 11 months ago

Fixed for 6.1 in MorphicExtras-pre.347 and MorphicExtrasTests-pre.8.

@marceltaeumel Do we want to consider this for backporting to 6.0?

marceltaeumel commented 11 months ago

Strange fix but I backported it. A call to #position: does never require an extra #fullBounds unless one immediatly requires updated, layout-specific geometry afterwards.

codeZeilen commented 11 months ago

A call to #position: does never require an extra #fullBounds unless one immediatly requires updated, layout-specific geometry afterwards.

Which is exactly what is required here. The setting of position is only used to force a layout of the submorphs in the AlignmentMorph. Afterwards the submorphs are extracted from the AlignmentMorph again and added to the actual PageMorph. The AlignmentMorph is only temporary.