squeaky-pl / japronto

Screaming-fast Python 3.5+ HTTP toolkit integrated with pipelining HTTP server based on uvloop and picohttpparser.
MIT License
8.61k stars 581 forks source link

Equalent go benchmark #12

Closed heppu closed 7 years ago

heppu commented 7 years ago

Fixes for #11

squeaky-pl commented 7 years ago

Hi, thanks for the PR. Have you managed to measure more or less what kind of speedup it makes over the previous version?

heppu commented 7 years ago

I haven't run benchmarks yet. Could you provide commands you used to run your benchmarks? Unrelated to performance, the go code in PR is little bit cleaner and easier to read so even though the performance wouldn't increase significantly. =)

Edit: Oh you had the wrk stuf in misc folder, my bad. I will run the test. =)

squeaky-pl commented 7 years ago

Great. Note that I run wrk 10 times in a row with -t 1-c 100 -d 2 and pipeline.lua script and took a median

heppu commented 7 years ago

Ok I ran the benchmark on the go version is 18% faster that the current go version on my machine.

squeaky-pl commented 7 years ago

waiting for go-fasthttp results and gonna put an errata in the article.

heppu commented 7 years ago

Oh sorry I forgot to set GOMAXPROCS=1. The increase was ~12% with that setup. I gotta say that that kind of takes away the advantage of Go but still is valid if you are planning to run http server on single thread instance :D